fix(examples): Update the argument for Runtime framework #2766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Pull Request Test Coverage Report for Build 16686412850Details
💛 - Coveralls |
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
andreyvelich
changed the title
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
|
@kramaranya @kubeflow/kubeflow-trainer-team @astefanutti Does these changes to the examples look good to you ? |
There was a problem hiding this comment.
@andreyvelich Thanks! The torchtune part LGTM!
/lgtm
/approve
/hold for review
|
/lgtm Thanks! |
tenzen-y
reviewed
Aug 4, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Electronic-Waste, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jaiakash
added a commit
to jaiakash/trainer
that referenced
this pull request
Aug 13, 2025
fix(examples): Update the argument for Runtime framework (kubeflow#2766)
|
/cherry-pick release-2.0 |
|
@astefanutti: #2766 failed to apply on top of branch "release-2.0": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
astefanutti
pushed a commit
to astefanutti/training-operator
that referenced
this pull request
Sep 23, 2025
* fix(examples): Update the runtime framework parameter Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Update TorchTune example Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Use wait_for_job_status API Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Fix Notebook Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Fix client Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Fix job name Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> --------- Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
1 task
astefanutti
pushed a commit
to astefanutti/training-operator
that referenced
this pull request
Sep 23, 2025
* fix(examples): Update the runtime framework parameter Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Update TorchTune example Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Use wait_for_job_status API Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Fix Notebook Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Fix client Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Fix job name Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> --------- Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>
astefanutti
pushed a commit
to astefanutti/training-operator
that referenced
this pull request
Sep 23, 2025
* fix(examples): Update the runtime framework parameter Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Update TorchTune example Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Use wait_for_job_status API Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Fix Notebook Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Fix client Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> * Fix job name Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> --------- Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr>
andreyvelich
added a commit
that referenced
this pull request
Sep 23, 2025
* fix(examples): Update the runtime framework parameter * Update TorchTune example * Use wait_for_job_status API * Fix Notebook * Fix client * Fix job name --------- Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com> Signed-off-by: Antonin Stefanutti <antonin@stefanutti.fr> Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should update examples according to our recent changes to the SDK: kubeflow/sdk#56
That should fix the failed examples.
/assign @kubeflow/kubeflow-trainer-team @astefanutti @kramaranya